Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amina/fix: close_button_on_responsive #7465

Conversation

amina-deriv
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • ...

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Jan 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 1, 2023 at 6:31AM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/7465](https://github.com/binary-com/deriv-app/pull/7465)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-amina-deriv-amina87410responsivebackb-f48479.binary.sx?qa_server=frontend.binaryws.com&app_id=24089
    - **Original**: https://deriv-app-git-fork-amina-deriv-amina87410responsivebackb-f48479.binary.sx
- **App ID**: `24089`

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 18
🟧 Accessibility 73
🟢 Best practices 100
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-amina-deriv-amina87410responsivebackb-f48479.binary.sx/

@codecov-commenter
Copy link

Codecov Report

Merging #7465 (9af1feb) into master (b6d9d79) will not change coverage.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master    #7465   +/-   ##
=======================================
  Coverage   20.00%   20.00%           
=======================================
  Files        1492     1492           
  Lines       35128    35128           
  Branches     6431     6431           
=======================================
  Hits         7026     7026           
  Misses      27527    27527           
  Partials      575      575           
Impacted Files Coverage Δ
packages/account/src/Containers/account.jsx 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@matin-deriv matin-deriv merged commit 97ee690 into binary-com:master Feb 1, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.1% 5.1% Duplication

bahar-sadeghzadeh pushed a commit to bahar-sadeghzadeh/deriv-app that referenced this pull request Feb 2, 2023
vinu-deriv added a commit that referenced this pull request Feb 6, 2023
* Feature/82781/diel_for_all (#7311)

* fix: exit button issue

* fix: hide currency selection modal if user has an mf mt5 account

* fix: fixed an error in mobile mode and added isOnboardingVisited again

* fix: remove toggleExitTradersHubModal action from traders-hub-store

* fix: css styles

* fix: currency selector for EU demo

* fix: currency auto selecting first currency after refresh

* fix: tradershub header issues on mobile

* fix: multipliers_status_badge

* fix: demo_low_risk flg in tradershub store

* fix: add or remove modal

* fix: reloading of account_switcher

* chore: update currency switcher styles

* chore: hide derivx for low_risk_cr_eu clients for real and demo

* chore: update styles for currency switcher

* fix: mt5 dashboard fix

* fix: test cases

* fix: test case

* fix: fixed the alignment issue of password-selection-modal

* fix: switching on exit traders modal

* chore: show appropriate information on the account switcher in the old UI

* fix: next button disabled in eu signup

* fix: test case fix

* fix: account switcher

* fix: manage account in account switcher

* fix: dxtrade error

* fix: redirecting for traders_hub

* fix: header traders hub cursor pointer

* fix: acc switcher

* fix: fixing issues of the tour guide

* fix: change regulations to regulation

* fix: regulations v2

* fix: icon and message

* fix: cursor pointer for status badge

* fix: mf real account signup width

* fix: real account signup modal

* fix: place of birth for eu

* fix: tests

* fix: fixed the scroll issue and added a new condition to tour guide

* fix: removed the redundant line of trading-hub-header

* fix: made a small change for the handle scroll function

* fix: replaced interval with timeout

* fix: hide idv for EU

* fix: some capital characters

* fix: signup modal title

* fix: regulation compare table scroll smooth

* fix: compare account modal

* fix: responsive alignment

* fix: fix popup content

* fix: malta description fix and styles

* fix: regulation responsive scroll

* fix: compare account modal

* fix: update jurisdiction content

* fix: jurisdiction content

* fix: get_more_btn

* fix: regulators

* fix: css for account type dropdown

* fix: add options account for eu

* fix: onboarding content desc

* fix: onboarding content at stage 5

* fix: onboarding platform names

* chore: hide region for new accounts

* fix: add options account

* fix: design-difference-in-transfer-popup

* fix: regulator table scroll

* fix: success modal meesage

* fix: responsive scroll dashboard

* fix: regulation switcher appearing for high risk

* fix: 86699_stock_to_stocks

* fix: fix add new account

* fix: traders hub header dark theme icon

* fix: tooltip description for non-eu

* fix: dropdown icon for onboarding currency switcher

* fix: add short code text for derived and financial accounts

* fix: eu currency switcher showing in non-eu

* fix: change dmt5 to deriv mt5 in total assets

* fix: cfd learn more link

* test: fix tests

* fix: dark_mode_status_badge

* fix: add icon for deriv and financial accounts in receipt

* refactor: code refactoring

* fix: transfer now to top-up now

* fix: total assets to be shown based on selected region

* fix: total assets to be shown based on selected region

* fix: loginid error on logout

* fix: show popover in mobile

* fix: disable click on tourguide overlay and remove setting accountType on tour guide

* fix: onboarding footer

* fix: test failure

* fix: fixed the background color issue of onboarding in dark theme

* fix: region seitcher in mobile view

* fix: fixed the glitch issue with onboarding

* fix: fixed the issue of tour guide

* fix: dont show loader if user has no account when switching

* fix: deposit now style in cashier transfer modal

* fix: dashboard title size

* fix: decreased the delays

* fix: redirect to static pages

* fix: fixed the localization issue of tour guide

* fix: remove balance when account has mt5 status

* fix: regulation switcher glitch in high risk

* fix: onboarding labels

* fix: pointer display

* fix: status badge icon overflow and total assets currency in dark theme

* fix: success_message

* fix: minor issues in contents

* fix: account from field should be tha same as trading account

* trigger codecov

* fix: top-up to transfer

* fix: switch account to real for demo_low_risk

* fix: can create deriv x account if user has no cr account and status badge icon css

* fix: status badge color inconsistency and size

* fix: deriv x trade modal huawei css

* fix: jurisdiction modal content

* Account fix selected to (#27)

* fix: default selected to account

* fix: account transfer switch to default client acc

* fix: onboarding footer text padding

* fix: real account needed modal for mt5 if user has no cr account

* fix: eu onboarding footer

* fix: redirect_to_traders_hub_on_entering_mt5_url

* fix: redirect derivx url

* fix: icon design mismatch (#26)

* fix: simplified the conditions

* test: fix test

* fix: fixed all conflicts

* refactor: code refactoring

* fix: salutation

* fix: short code visibility

* fix: fix short code visibility

* refactor: code refactoring

* fix: remove icon for derivx trade modal

* fix: fixed the issue where is_pre_appstore was retrived from another place

* fix: add Assets alias to webpack/tsconfig, refactor imports

* test: fix jest config

* fix: default page should be demo in onboarding

* fix: freeze_mg_acc_on_cooling_perios

* fix: onboarding buttons

* fix: transfer_form_from_account_style

* fix: mt5 trade modal css alignment

* chore: hide disclaimer for low-risk clients

* fix: notification console error

* chore: add volatility in regulator modal

* fix: account_transfer_title

* chore: add disclamer to low risk eu

* fix: asterik_on_required_fields

* fix: adding loader to total asset balance on switching

* fix: loader

* fix: loader console error

* fix: regulation switcher glitch when switching

* fix: add back react content loader

* fix: safari styling shiii

* fix: close button on on boarding

* fix: Trader's hub title

* fix: disclaimer text change

* fix: all dem loaders

* fix: up/dpwn icon

* fix: dmt5 paswrd

* fix: low_risk flag in dbot

* fix: fix layout shift on safari

* fix: servererror component fix

* fix: circleci  and typo

* fix: header loader

* fix: investor password

* fix: merge conflicts

---------

Co-authored-by: amina-deriv <amina@deriv.com>
Co-authored-by: mahdiyeh-deriv <82078941+mahdiyeh-deriv@users.noreply.github.com>
Co-authored-by: Thisyahlen <thisyahlen@regentmarkets.com>
Co-authored-by: Hirad <hirad@re-work.dev>
Co-authored-by: mahdiyeh-fs <mahdiyeh@firstsource.tech>
Co-authored-by: Jim Daniels Wasswa <jim@deriv.com>
Co-authored-by: Thisyahlen Nair <thisyahlennair@Thisyahlens-MacBook-Pro.local>
Co-authored-by: Bahar <bahar@regentmarkets.com>
Co-authored-by: george-usynin-binary <heorhi@binary.com>
Co-authored-by: GeorgeUsynin <70709786+GeorgeUsynin@users.noreply.github.com>

* translations: 📚 sync translations with crowdin (#7458)

Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>

* translations: 📚 sync translations with crowdin (#7460)

Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>

* translations: 📚 sync translations with crowdin (#7461)

Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>

* chore: remove boom description for eu regulation (#7467)

* Amina/87406/fix: exit modal fix (#7464)

* fix: exit modal fix

* chore: empty commit to trigger vercel deployment

---------

Co-authored-by: Matin shafiei <matin@deriv.com>

* fix: empty notification dropdown (#7468)

Co-authored-by: Yashim Wong <yashim@deriv.com>

* fix: close_button_on_responsive (#7465)

* Amina/fix: cfd listing fix (#7463)

* fix: cfd listing

* chore: empty commit to trigger vercel deployment

---------

Co-authored-by: Matin shafiei <matin@deriv.com>

* fix: console_error (#7482)

* bahar/87404/fix: deposit_locked_for_cr_account (#7473)

* fix: deposit_locked_in_for_cr_account

* fix: circleci_issues

* fix: is_eu_for_cashier

* fix: my ads

---------

Co-authored-by: Farrah Mae Ochoa <farrah@deriv.com>
Co-authored-by: Nijil Nirmal <62882794+nijil-deriv@users.noreply.github.com>

* fix: trade button (#7483)

Co-authored-by: vinu-deriv <100689171+vinu-deriv@users.noreply.github.com>

* Mahdiyeh/ fix: showing notice popup for LOW_RISK/NON_EU (#7477)

* fix: showing notice popup for LOW_RISK/NON_EU

* fix: useEffect

* thisyahlen/fix: exit traders hub and account switcher (#7480)

* fix: exit traders hub and account switcher

* fix: exit traders hub and account switcher

* fix: fix add deriv account in acc switcher

* fix: idv showing for eu regulation add account

---------

Co-authored-by: Matin shafiei <matin@deriv.com>
Co-authored-by: amina-deriv <amina@deriv.com>
Co-authored-by: mahdiyeh-deriv <82078941+mahdiyeh-deriv@users.noreply.github.com>
Co-authored-by: Thisyahlen <thisyahlen@regentmarkets.com>
Co-authored-by: Hirad <hirad@re-work.dev>
Co-authored-by: mahdiyeh-fs <mahdiyeh@firstsource.tech>
Co-authored-by: Jim Daniels Wasswa <jim@deriv.com>
Co-authored-by: Thisyahlen Nair <thisyahlennair@Thisyahlens-MacBook-Pro.local>
Co-authored-by: george-usynin-binary <heorhi@binary.com>
Co-authored-by: GeorgeUsynin <70709786+GeorgeUsynin@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com>
Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com>
Co-authored-by: Yashim Wong <yashim@deriv.com>
Co-authored-by: Farrah Mae Ochoa <farrah@deriv.com>
Co-authored-by: Nijil Nirmal <62882794+nijil-deriv@users.noreply.github.com>
Co-authored-by: vinu-deriv <100689171+vinu-deriv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants